From: Etienne Dechamps Date: Sat, 12 Jul 2014 10:13:04 +0000 (+0100) Subject: Don't initialize outpkt to an unused value. X-Git-Tag: release-1.1pre11~70 X-Git-Url: https://git.tinc-vpn.org/git/browse?a=commitdiff_plain;h=127f2f99f3d43e0565782750f26f1d3980c72711;p=tinc Don't initialize outpkt to an unused value. in receive_udppacket(), we initialize outpkt to a default value but the value is never read anywhere, as every read is preceded by a write. This issue was found by the clang static analyzer tool: http://clang-analyzer.llvm.org/ --- diff --git a/src/net_packet.c b/src/net_packet.c index 609b4527..c8cd0ca7 100644 --- a/src/net_packet.c +++ b/src/net_packet.c @@ -360,7 +360,6 @@ static void receive_udppacket(node_t *n, vpn_packet_t *inpkt) { vpn_packet_t pkt1, pkt2; vpn_packet_t *pkt[] = { &pkt1, &pkt2, &pkt1, &pkt2 }; int nextpkt = 0; - vpn_packet_t *outpkt = pkt[0]; size_t outlen; if(n->status.sptps) { @@ -402,7 +401,7 @@ static void receive_udppacket(node_t *n, vpn_packet_t *inpkt) { /* Decrypt the packet */ if(cipher_active(n->incipher)) { - outpkt = pkt[nextpkt++]; + vpn_packet_t *outpkt = pkt[nextpkt++]; outlen = MAXSIZE; if(!cipher_decrypt(n->incipher, &inpkt->seqno, inpkt->len, &outpkt->seqno, &outlen, true)) { @@ -459,7 +458,7 @@ static void receive_udppacket(node_t *n, vpn_packet_t *inpkt) { length_t origlen = inpkt->len; if(n->incompression) { - outpkt = pkt[nextpkt++]; + vpn_packet_t *outpkt = pkt[nextpkt++]; if((outpkt->len = uncompress_packet(outpkt->data, inpkt->data, inpkt->len, n->incompression)) < 0) { logger(DEBUG_TRAFFIC, LOG_ERR, "Error while uncompressing packet from %s (%s)",