From: Guus Sliepen <guus@tinc-vpn.org>
Date: Sun, 7 Dec 2014 16:25:30 +0000 (+0100)
Subject: Log an error message with the node's name when receiving bad SPTPS packets.
X-Git-Tag: release-1.1pre11~28
X-Git-Url: https://git.tinc-vpn.org/git/browse?a=commitdiff_plain;h=b90c42a33b78f22b7046da5a5445c712020f30eb;p=tinc

Log an error message with the node's name when receiving bad SPTPS packets.

The SPTPS code doesn't know about nodes, so when it logs an error about
a bad packet, it doesn't log which node it came from. So add a log
message with the node's name and hostname in receive_udppacket().
---

diff --git a/src/net_packet.c b/src/net_packet.c
index eb6ecfa4..c3e8c624 100644
--- a/src/net_packet.c
+++ b/src/net_packet.c
@@ -372,7 +372,11 @@ static bool receive_udppacket(node_t *n, vpn_packet_t *inpkt) {
 			}
 			return false;
 		}
-		return sptps_receive_data(&n->sptps, (char *)&inpkt->seqno, inpkt->len);
+		if(!sptps_receive_data(&n->sptps, (char *)&inpkt->seqno, inpkt->len)) {
+			logger(DEBUG_TRAFFIC, LOG_ERR, "Got bad packet from %s (%s)", n->name, n->hostname);
+			return false;
+		}
+		return true;
 	}
 
 	if(!n->status.validkey) {