From: Etienne Dechamps <etienne@edechamps.fr>
Date: Sun, 7 Jan 2018 14:26:00 +0000 (+0000)
Subject: Fix AC_CHECK_DECLS usage in openssl.m4.
X-Git-Tag: release-1.1pre16~35
X-Git-Url: https://git.tinc-vpn.org/git/browse?a=commitdiff_plain;h=ddf798a0ef7df21d682d2f6763d5417400c987ba;p=tinc

Fix AC_CHECK_DECLS usage in openssl.m4.

See:

  https://www.gnu.org/software/autoconf/manual/autoconf-2.62/html_node/Generic-Declarations.html

"For each of the symbols (comma-separated list)"

When building with aggressive warning settings the current code results
in the following configure test code being generated:

  #ifndef OpenSSL_add_all_algorithms EVP_aes_256_cfb
  #ifdef __cplusplus
    (void) OpenSSL_add_all_algorithms EVP_aes_256_cfb;
  #else
    (void) OpenSSL_add_all_algorithms EVP_aes_256_cfb;
  #endif
  #endif

Which is obviously wrong and makes the configure check fail.
---

diff --git a/m4/openssl.m4 b/m4/openssl.m4
index 4afcff2f..ca9bbb55 100644
--- a/m4/openssl.m4
+++ b/m4/openssl.m4
@@ -49,7 +49,7 @@ AC_DEFUN([tinc_OPENSSL],
     [AC_MSG_ERROR([Missing LibreSSL/OpenSSL functionality, make sure you have installed the latest version.]); break],
   )
 
-  AC_CHECK_DECLS([OpenSSL_add_all_algorithms EVP_aes_256_cfb], ,
+  AC_CHECK_DECLS([OpenSSL_add_all_algorithms, EVP_aes_256_cfb], ,
     [AC_MSG_ERROR([Missing LibreSSL/OpenSSL functionality, make sure you have installed the latest version.]); break],
     [#include <openssl/evp.h>]
   )