Guus Sliepen [Mon, 25 May 2009 13:04:33 +0000 (15:04 +0200)]
Do not forward broadcast packets when TunnelServer is enabled.
First of all, the idea behind the TunnelServer option is to hide all other
nodes from each other, so we shouldn't forward broadcast packets from them
anyway. The other reason is that since edges from other nodes are ignored, the
calculated minimum spanning tree might not be correct, which can result in
routing loops.
Guus Sliepen [Mon, 25 May 2009 10:19:37 +0000 (12:19 +0200)]
Use packet size before decompression to calculate path MTU.
Since compression can either grow or shrink a packet, the size of an MTU probe
after decompression might not reflect the real path MTU. Now we use the size
before decompression, which is independent of the compression algorithm, and
substract a safety margin such that the calculated path MTU will be safe even
for packets which grow as much as possible after compression.
Guus Sliepen [Mon, 25 May 2009 10:19:08 +0000 (12:19 +0200)]
Add declaration for sockaddrcmp_noport().
Michael Tokarev [Sun, 24 May 2009 18:32:24 +0000 (22:32 +0400)]
Fix ans_key exchange in recent changes
send_ans_key() was using the wrong in vs. outkeylength to
terminate the key being sent, so it was always empty.
Guus Sliepen [Sun, 24 May 2009 17:35:51 +0000 (19:35 +0200)]
Use xrealloc instead of if(ptr) ptr = xmalloc().
Guus Sliepen [Sun, 24 May 2009 17:31:31 +0000 (19:31 +0200)]
Fix initialisation of packet decryption context broken by commit
3308d13e7e3bf20cfeaf6f2ab17228a9820cea66.
Instead of a single, global decryption context, each node has its own context.
However, in send_ans_key(), the global context was initialised. This commit
fixes that and removes the global context completely.
Also only set status.validkey after all checks have been evaluated.
Michael Tokarev [Thu, 21 May 2009 21:10:16 +0000 (01:10 +0400)]
don't log every strange packet coming to the UDP port
it's a sure way to fill up syslog. Only log those if
debug level is up to PROTOCOL
Guus Sliepen [Sun, 24 May 2009 15:13:00 +0000 (17:13 +0200)]
Fix link to Mattias Nissler's tun/tap driver for MacOS/X.
Thanks to Martin Christof Kindsmüller for spotting.
Guus Sliepen [Sun, 24 May 2009 13:58:47 +0000 (15:58 +0200)]
If PMTUDiscovery is not set, do not forward packets via TCP unnecessarily.
Michael Tokarev [Thu, 21 May 2009 21:01:35 +0000 (01:01 +0400)]
ignore indirect edge registrations in tunnelserver mode
In tunnelserver mode we're not interested to hear about
our client edges, just like in case of subnets. Just
ignore all requests which are not about our node or the
client node.
The fix is very similar to what was done for subnets.
Note that we don't need to add the "unknown" nodes to
the list in tunnelserver mode too, so move allocation
of new nodes down the line.
Michael Tokarev [Wed, 20 May 2009 14:40:04 +0000 (18:40 +0400)]
TunnelServer: Don't disconnect client on DEL_SUBNET too
Similar changes as was in
2327d3f6eb5982bcc922ff1ab1ec436ba6aeffdc
but for del_subnet_h().
Before, we vere returning false (and causing disconnect of the
client) in case of tunnelserver and the client sending DEL_SUBNET
for non-his subnet or for subnet which owner isn't in our connection
list.
After the mentioned change to add_subnet_h() that routine does not
add such indirect owners to the connection list anymore, so that
was ok (owner == NULL and we return true).
But if we too has a connection with the node about which the client
is sending DEL_SUBNET notification, say, because that client lost
connection with that other node, we'll disconnect this client from
us too, returning false for indirect DEL_SUBNET.
Fix that by allowing and ignoring indirect DEL_SUBNET in tunnelserver
mode.
Also rearranged the function a bit, to match add_subnet_h() (in
particular, syntax-check everything first, see if we've seen this
request before).
And also fix some comments.
Michael Tokarev [Mon, 18 May 2009 13:34:30 +0000 (17:34 +0400)]
format 'not supported on this platform' error message
Format it in a similar way in all places, to make translation happier.
No functional changes.
Michael Tokarev [Mon, 18 May 2009 13:00:00 +0000 (17:00 +0400)]
change error messages in droppriv code to match the rest
Change formatting of error messages about failed syscalls
to be the same as in other places in tincd.
Also suggest a change in "$foo not supported on this platform"
message as it's now used more than once.
Michael Tokarev [Mon, 18 May 2009 12:53:08 +0000 (16:53 +0400)]
bugfix: chdir(/) after chroot
Fix the famous chdir(".") vs chdir("/") after chroot(something).
Michael Tokarev [Mon, 18 May 2009 12:49:39 +0000 (16:49 +0400)]
bugfix: move mlock to after detach() so it works for child, not parent
mlock()/mlockall() are not persistent across fork(), and it's
done in parent process before daemon() which does fork(). So
basically, current --mlock does nothing useful.
Move mlock() to after detach() so it works for child process
instead of parent.
Also, check if the platform supports mlock right when processing
options (since else we'll have to die after startup, not at
startup, the error message will be in log only).
Michael Tokarev [Mon, 18 May 2009 12:28:55 +0000 (16:28 +0400)]
bugfix: initialize pid (as read from pidfile) to zero
If we didn't read any number from a pid file, we'll return
an unitialized variable to the caller, and it will treat
that garbage as a pid of a process (possible to kill).
Fix that.
Michael Tokarev [Mon, 18 May 2009 12:25:41 +0000 (16:25 +0400)]
Implement privilege dropping
Add two options, -R/--chroot and -U/--user=user, to chroot to the
config directory (where tinc.conf is located) and to perform
setuid to the user specified, after all the initialization is done.
What's left is handling of pid file since we can't remove it anymore.
Michael Tokarev [Mon, 18 May 2009 12:25:10 +0000 (16:25 +0400)]
Rename setup_network_connections() and split out try_outgoing_connections()
In preparation of chroot/setuid operations, split out call to
try_outgoing_connections() from setup_network_connections()
(which was the last call in setup_network_connections()).
This is because dropping privileges should be done in-between
setup_network_connections() and try_outgoing_connections().
This patch renames setup_network_connections() to setup_network()
and moves call to try_outgoing_connections() into main routine.
No functional changes.
Guus Sliepen [Thu, 2 Apr 2009 23:05:23 +0000 (01:05 +0200)]
Handle UDP packets from different and ports than advertised.
Previously, tinc used a fixed address and port for each node for UDP packet
exchange. The port was the one advertised by that node as its listening port.
However, due to NAT the port might be different. Now, tinc sends a different
session key to each node. This way, the sending node can be determined from
incoming packets by checking the MAC against all session keys. If a match is
found, the address and port for that node are updated.
Guus Sliepen [Mon, 9 Mar 2009 13:04:31 +0000 (14:04 +0100)]
Use a simple Random Early Drop algorithm in send_tcppacket().
Guus Sliepen [Mon, 9 Mar 2009 12:48:54 +0000 (13:48 +0100)]
Disable PMTUDiscovery in switch and hub modes.
In switch and hub modes, tinc does not generate ICMP packets in response to
packets that are larger than the path MTU. However, if PMTUDiscovery is
enabled, the IP_MTU_DISCOVER and IPV6_MTU_DISCOVER option is set on the UDP
sockets, which causes all UDP packets to be sent with the DF bit set, causing
large packets to be dropped, even if they would otherwise be routed fine.
Guus Sliepen [Thu, 5 Mar 2009 13:12:36 +0000 (14:12 +0100)]
Update THANKS and copyright information.
Guus Sliepen [Thu, 5 Mar 2009 12:34:13 +0000 (13:34 +0100)]
Allow weight to be assigned to Subnets.
Tinc allows multiple nodes to own the same Subnet, but did not have a sensible
way to decide which one to send packets to. Tinc also did not check the
reachability of nodes when deciding where to route packets to, so it would not
automatically fail over to a reachable node.
Tinc now assigns a weight to each Subnet. The default weight is 10, with lower
weights having higher priority. The Subnets are now internally sorted in the
same way as the kernel's routing table, and the Subnets are search linearly,
skipping those of unreachable nodes. A small cache of recently used addresses
is used to speed up the lookup functions.
Michael Tokarev [Sat, 28 Feb 2009 13:37:51 +0000 (16:37 +0300)]
Enable PMTUDiscovery only if BOTH sides wants it.
Don't enable PMTUDiscovery if at least one side does not support it.
Before it was enabled if at least one side supported it, now both are required.
Guus Sliepen [Tue, 17 Feb 2009 13:43:05 +0000 (14:43 +0100)]
Handle neighbor solicitation requests without link layer addresses.
Apparently FreeBSD likes to send out neighbor solicitation requests, even on a
tun interface where this is completely pointless. These requests do not have an
option header containing a link layer address, so the proxy-neighborsol code
was treating these requests as invalid. We now handle such requests, and send
back equally pointless replies, also without a link layer address. This seems
to satisfy FreeBSD.
Michael Tokarev [Mon, 9 Feb 2009 22:51:10 +0000 (23:51 +0100)]
Allow tunnelserver to work with clients that have other peers.
In TunnelServer mode, tinc server disconnects any client if it announces
indirect subnets -- subnets that are not theirs (e.g. subnets for nodes
the CLIENT has connections now, even if those nodes are known to the server
too). Fix that by ignoring such (indirect) announces instead.
While we're at it, move check for such indirect subnet registration to
before allocating new node structure, as in TunnelServer mode we don't
really need to know that other node.
Guus Sliepen [Tue, 3 Feb 2009 13:54:45 +0000 (14:54 +0100)]
Disable old RSA keys when generating new ones.
When generating an RSA keypair, the new public and private keys are appended to
files. However, when OpenSSL reads keys it only reads the first in a file, not
the last. Instead of printing an easily ignored warning, tinc now disables old
keys when appending new ones.
Guus Sliepen [Tue, 20 Jan 2009 13:21:50 +0000 (14:21 +0100)]
Validate Name before using it in a filename when generating a keypair.
Guus Sliepen [Tue, 20 Jan 2009 13:20:44 +0000 (14:20 +0100)]
Allow reading config files with CRLF endings on Unix systems.
Guus Sliepen [Tue, 20 Jan 2009 12:19:31 +0000 (13:19 +0100)]
Remove unused definitions from net.h.
Guus Sliepen [Tue, 20 Jan 2009 12:12:41 +0000 (13:12 +0100)]
Use a global list to track outgoing connections.
Previously an outgoing_t was maintained for each outgoing connection,
but the pointer to it was either stored in a connection_t or in an event_t.
This made it very hard to keep track of and to clean up.
Now a list is created when tinc starts and reads all the ConnectTo variables,
and which is recreated when tinc receives a HUP signal.
Guus Sliepen [Mon, 19 Jan 2009 22:17:28 +0000 (23:17 +0100)]
Add missing cleanup functions in close_network_connections().
Guus Sliepen [Mon, 19 Jan 2009 21:50:05 +0000 (22:50 +0100)]
Change flush_events() to expire_events().
The former function made a totally bogus shallow copy of the event_tree, called
the handler of each event and then deleted the whole tree. This should've
caused tinc to crash when an ALARM signal was sent more than once, but for some
reason it didn't. It also behaved incorrectly when a handler added a new event.
The new function just moves the expiration time of all events to the past.
Guus Sliepen [Fri, 9 Jan 2009 11:36:06 +0000 (12:36 +0100)]
Move free()s at the end om main() to the proper destructor functions.
Guus Sliepen [Sat, 3 Jan 2009 21:33:55 +0000 (22:33 +0100)]
Only send packets via UDP if UDP communication is possible.
When no session key is known for a node, or when it is doing PMTU discovery but
no MTU probes have returned yet, packets are sent via TCP. Some logic is added
to make sure intermediate nodes continue forwarding via TCP. The per-node
packet queue is now no longer necessary and has been removed.
Guus Sliepen [Sat, 3 Jan 2009 21:06:10 +0000 (22:06 +0100)]
Consistently allocate device and iface variables on the heap.
This fixes a segfault when no Device has been specified and tinc exits, and it
would try to free() a static string. Thanks to Borg for spottin.
Guus Sliepen [Sat, 27 Dec 2008 10:09:43 +0000 (11:09 +0100)]
Update documentation for git.
Guus Sliepen [Fri, 26 Dec 2008 13:47:34 +0000 (13:47 +0000)]
Releasing 1.0.9.
Guus Sliepen [Fri, 26 Dec 2008 12:46:45 +0000 (12:46 +0000)]
Add missing parentheses in check for IPv4 multicast addresses.
Guus Sliepen [Tue, 23 Dec 2008 23:14:37 +0000 (23:14 +0000)]
Apply patch from Max Rijevski fixing a memory leak when closing connections.
It also cleans up more when stopping tinc, helping tools like valgrind.
Guus Sliepen [Tue, 23 Dec 2008 22:31:38 +0000 (22:31 +0000)]
Handle broadcast and multicast packets in router mode.
Multicast packets are treated as broadcast packets.
Based on a patch from Max Rijevski.
Guus Sliepen [Mon, 22 Dec 2008 21:49:23 +0000 (21:49 +0000)]
Update the manpage as well, and some whitespace to make its source more legible.
Guus Sliepen [Mon, 22 Dec 2008 21:29:21 +0000 (21:29 +0000)]
Update documentation.
- TCPOnly is not experimental.
- Do not mention old Linux kernels and Ethertap anymore.
- Document the DeviceType, PMTU and PMTUDiscovery options.
Guus Sliepen [Mon, 22 Dec 2008 20:35:45 +0000 (20:35 +0000)]
Enable PMTU discovery by default.
Guus Sliepen [Mon, 22 Dec 2008 20:27:52 +0000 (20:27 +0000)]
Update copyright information.
Guus Sliepen [Mon, 22 Dec 2008 19:43:49 +0000 (19:43 +0000)]
Update Dutch translation.
Guus Sliepen [Mon, 22 Dec 2008 19:40:40 +0000 (19:40 +0000)]
Make sure IPv6 sockets are IPv6 only.
This will get rid of the "Can't bind to 0.0.0.0 port 655/tcp: Address already
in use" message on Linux.
Guus Sliepen [Mon, 22 Dec 2008 19:33:37 +0000 (19:33 +0000)]
Use TUNIFHEAD by default on FreeBSD to make sure IPv6 works.
Guus Sliepen [Sun, 21 Dec 2008 16:19:31 +0000 (16:19 +0000)]
Treat virtual network device as tap if Mode = switch or hub.
On OpenBSD, the link0 flag should still be set in tinc-up or by other means.
Guus Sliepen [Fri, 5 Dec 2008 14:17:39 +0000 (14:17 +0000)]
Correct debug message.
Guus Sliepen [Tue, 18 Nov 2008 15:11:27 +0000 (15:11 +0000)]
Prevent freeing a NULL pointer when a hostname is unresolvable.
Guus Sliepen [Sat, 25 Oct 2008 19:54:00 +0000 (19:54 +0000)]
Do not try to send REQ_KEY or ANS_KEY requests to unreachable nodes.
Guus Sliepen [Sat, 25 Oct 2008 18:10:08 +0000 (18:10 +0000)]
Fix reading configuration files that do not end with a newline.
Guus Sliepen [Fri, 14 Dec 2007 21:17:08 +0000 (21:17 +0000)]
Make sure the prefixlength of subnets is sane.
Thanks to Sven-Haegar Koch for spotting the bug and providing a fix.
Guus Sliepen [Fri, 17 Aug 2007 22:09:00 +0000 (22:09 +0000)]
Handle SERVICE_CONTROL_INTERROGATE requests. Thanks to Carsten Ralle for noticing this.
Guus Sliepen [Wed, 16 May 2007 17:16:09 +0000 (17:16 +0000)]
Releasing 1.0.8.
Guus Sliepen [Wed, 16 May 2007 14:46:25 +0000 (14:46 +0000)]
Don't free struct addrinfo too early. Spotted by Christian Cier-Zniewski.
Guus Sliepen [Wed, 16 May 2007 14:42:41 +0000 (14:42 +0000)]
Update dutch translation.
Guus Sliepen [Wed, 16 May 2007 14:42:08 +0000 (14:42 +0000)]
Make sure connection->name is never NULL.
Guus Sliepen [Mon, 14 May 2007 09:21:09 +0000 (09:21 +0000)]
Apply patch from "dnk" making sockets non-blocking under Windows.
Guus Sliepen [Wed, 14 Feb 2007 09:32:16 +0000 (09:32 +0000)]
Close the proper filedescriptor (if it exists).
Guus Sliepen [Wed, 14 Feb 2007 09:21:34 +0000 (09:21 +0000)]
Apply patch from Scott Lamb fixing some memory and resource leaks.
Guus Sliepen [Wed, 14 Feb 2007 09:20:20 +0000 (09:20 +0000)]
Apply patch from Scott Lamb preventing an infinite loop when sending SIGALRM.
Guus Sliepen [Fri, 5 Jan 2007 15:03:07 +0000 (15:03 +0000)]
Releasing 1.0.7.
Guus Sliepen [Fri, 5 Jan 2007 13:18:36 +0000 (13:18 +0000)]
Update copyright notices.
Guus Sliepen [Fri, 5 Jan 2007 13:17:33 +0000 (13:17 +0000)]
No things to do for the 1.0 branch except bugfixing.
Guus Sliepen [Fri, 5 Jan 2007 05:44:01 +0000 (05:44 +0000)]
rename() cannot replace existing files on Windows.
Guus Sliepen [Fri, 5 Jan 2007 04:49:02 +0000 (04:49 +0000)]
Fix generic BSD tun device to write only the actual packet length.
Due to a copy&paste bug, it tried to write a packet with the maximum size.
This was not a problem until the maximum size was increased to support VLANs.
Guus Sliepen [Thu, 4 Jan 2007 15:28:36 +0000 (15:28 +0000)]
Tapreader socket should be bound to localhost only.
Guus Sliepen [Wed, 3 Jan 2007 18:18:54 +0000 (18:18 +0000)]
Use a ringbuffer in shared memory to transfer packets from the tapreader thread to the main thread.
It's a wonder it ever worked before. The socket that is created is not of a
datagram type, therefore packet boundaries were not preserved, which becomes
a problem as soon as the TAP-Win32 device receives packets in fast succession.
Guus Sliepen [Mon, 18 Dec 2006 17:38:05 +0000 (17:38 +0000)]
Releasing 1.0.6.
Guus Sliepen [Mon, 18 Dec 2006 11:41:53 +0000 (11:41 +0000)]
Prevent compiler warnings about redefinition of EAI_FAMILY on FreeBSD 6.1.
Guus Sliepen [Sat, 16 Dec 2006 16:53:58 +0000 (16:53 +0000)]
Do a simple test for linux/if_tun.h instead of no test at all.
Guus Sliepen [Sat, 16 Dec 2006 16:40:09 +0000 (16:40 +0000)]
Remove the test for linux/if_tun.h.
It has been available for years on any decent Linux distribution.
Although linux/if_tun.h is now required to compile tinc,
you can still run it on systems which only support Ethertap.
Guus Sliepen [Sat, 16 Dec 2006 16:34:04 +0000 (16:34 +0000)]
We do properly check for malloc and realloc.
Guus Sliepen [Sat, 16 Dec 2006 16:26:57 +0000 (16:26 +0000)]
Use standard autoconf macros instead of our own.
Guus Sliepen [Sat, 16 Dec 2006 16:26:08 +0000 (16:26 +0000)]
Fix rule that creates html version of manpages.
Guus Sliepen [Fri, 15 Dec 2006 20:44:33 +0000 (20:44 +0000)]
Remove old Spanish translation.
Guus Sliepen [Fri, 15 Dec 2006 20:43:39 +0000 (20:43 +0000)]
Remove unnecessary stuff from configure.in.
Guus Sliepen [Tue, 12 Dec 2006 14:54:39 +0000 (14:54 +0000)]
Use the correct next pointer.
Guus Sliepen [Tue, 12 Dec 2006 14:49:09 +0000 (14:49 +0000)]
When building the minimum spanning tree, make sure we start from a reachable node.
Guus Sliepen [Wed, 29 Nov 2006 17:18:39 +0000 (17:18 +0000)]
Search for lzo/lzo1x.h, lzo2/lzo1x.h and lzo1x.h.
Guus Sliepen [Wed, 29 Nov 2006 16:57:46 +0000 (16:57 +0000)]
Make sure resolved addressed for outgoing connections are freed, if there are any.
Guus Sliepen [Tue, 14 Nov 2006 15:43:28 +0000 (15:43 +0000)]
Releasing 1.0.5.
Guus Sliepen [Tue, 14 Nov 2006 12:28:04 +0000 (12:28 +0000)]
EWOULDBLOCK does not exist on platforms without O_NONBLOCK
Guus Sliepen [Sat, 11 Nov 2006 22:45:45 +0000 (22:45 +0000)]
When deleting an entire tree, start at head, not at root.
Guus Sliepen [Sat, 11 Nov 2006 22:44:15 +0000 (22:44 +0000)]
Nodes use events, so event system should be initialised first and destroyed last.
Guus Sliepen [Sat, 11 Nov 2006 21:37:22 +0000 (21:37 +0000)]
Update Dutch translation.
Guus Sliepen [Sat, 11 Nov 2006 20:37:58 +0000 (20:37 +0000)]
Document GraphDumpFile option.
Guus Sliepen [Sat, 11 Nov 2006 20:10:46 +0000 (20:10 +0000)]
Support and autodetect LZO version 2.0 and later.
Guus Sliepen [Sat, 11 Nov 2006 20:06:14 +0000 (20:06 +0000)]
Support and autodetect LZO version 2.0 and later.
Guus Sliepen [Sat, 11 Nov 2006 14:37:03 +0000 (14:37 +0000)]
popen() requires pclose().
Guus Sliepen [Sat, 11 Nov 2006 14:11:16 +0000 (14:11 +0000)]
Added graph dumping ability based on Markus Goetz's patch.
Guus Sliepen [Sat, 11 Nov 2006 13:43:00 +0000 (13:43 +0000)]
The "active" bit in node.status is not used.
Guus Sliepen [Wed, 9 Aug 2006 22:31:10 +0000 (22:31 +0000)]
memcpy() addresses from packet headers before calling the lookup functions.
This probably fixes a problem on the ARM architecture that causes tinc to fail to lookup IPv4 addresses.
Guus Sliepen [Tue, 8 Aug 2006 13:50:58 +0000 (13:50 +0000)]
Remove unused variable.
Guus Sliepen [Tue, 8 Aug 2006 13:44:37 +0000 (13:44 +0000)]
Remove unused parameter from maskcmp().
Guus Sliepen [Tue, 8 Aug 2006 13:44:19 +0000 (13:44 +0000)]
Remove unused variables.
Guus Sliepen [Tue, 8 Aug 2006 13:29:17 +0000 (13:29 +0000)]
Fix format string warnings.
Guus Sliepen [Tue, 8 Aug 2006 13:21:08 +0000 (13:21 +0000)]
Do not break strict aliasing of status_t structs.